adoroszlai commented on code in PR #10596:
URL: https://github.com/apache/ozone/pull/10596#discussion_r3472339032
##########
hadoop-ozone/freon/src/main/java/org/apache/hadoop/ozone/freon/RandomKeyGenerator.java:
##########
@@ -290,6 +290,30 @@ public void init(OzoneConfiguration configuration) throws
IOException {
}
}
+ private void validateCounts() {
+ if (numOfVolumes <= 0) {
+ throw new IllegalArgumentException(
+ "Invalid command, --num-of-volumes must be a positive integer");
+ }
+ if (numOfBuckets <= 0) {
+ throw new IllegalArgumentException(
+ "Invalid command, --num-of-buckets must be a positive integer");
+ }
+ if (numOfKeys <= 0) {
+ throw new IllegalArgumentException(
+ "Invalid command, --num-of-keys must be a positive integer");
+ }
+ if (numOfThreads <= 0) {
+ throw new IllegalArgumentException(
+ "Invalid command, --num-of-threads must be a positive integer");
+ }
+ if (validateWrites && numOfValidateThreads <= 0) {
+ throw new IllegalArgumentException(
+ "Invalid command, --num-of-validate-threads must be a positive
integer");
+ }
+ }
+
+
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
