adoroszlai commented on code in PR #10469:
URL: https://github.com/apache/ozone/pull/10469#discussion_r3475342867
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMAllocateBlockRequest.java:
##########
@@ -105,7 +105,7 @@ public OMRequest preExecute(OzoneManager ozoneManager)
throws IOException {
// BlockOutputStreamEntryPool, so we are fine for now. But if one some
// one uses direct omclient we might be in trouble.
- UserInfo userInfo = getUserIfNotExists(ozoneManager);
+ UserInfo userInfo = getUserInfo();
Review Comment:
The call to `super.preExecute` has already calculated and set `userInfo` on
`omRequest`.
```suggestion
UserInfo userInfo = getOmRequest().getUserInfo();
```
We can also remove `setUserInfo(userInfo)` below:
https://github.com/apache/ozone/blob/6fd72bd7602273270d0a2445268dac9a40ae413d/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMAllocateBlockRequest.java#L145
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRenameRequest.java:
##########
@@ -95,7 +95,7 @@ public OMRequest preExecute(OzoneManager ozoneManager) throws
IOException {
return getOmRequest().toBuilder()
.setRenameKeyRequest(renameKeyRequest.toBuilder().setToKeyName(dstKey)
.setKeyArgs(resolvedArgs))
- .setUserInfo(getUserIfNotExists(ozoneManager)).build();
+ .setUserInfo(getUserInfo()).build();
Review Comment:
```suggestion
.build();
```
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyDeleteRequest.java:
##########
@@ -92,7 +92,7 @@ public OMRequest preExecute(OzoneManager ozoneManager) throws
IOException {
return getOmRequest().toBuilder()
.setDeleteKeyRequest(deleteKeyRequest.toBuilder()
.setKeyArgs(resolvedArgs))
- .setUserInfo(getUserIfNotExists(ozoneManager)).build();
+ .setUserInfo(getUserInfo()).build();
Review Comment:
```suggestion
.build();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
