ivandika3 commented on PR #10598: URL: https://github.com/apache/ozone/pull/10598#issuecomment-4801616831
Thanks @hevinhsu for the patch, I'll review this soon. > Let me know if you'd like more test scenarios covered or if the tests should be included in this PR. @hevinhsu I think it's good to include the rack placement tests and we can add a test for each of the container placement policy. For the TestScmHAFinalizationWithRacks and TestSecretKeySnapshotWithRack I don't think they are affected by the the topology so might not be needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
