szetszwo commented on code in PR #10522:
URL: https://github.com/apache/ozone/pull/10522#discussion_r3478019867
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/StreamBlockInputStream.java:
##########
@@ -447,6 +461,7 @@ private ByteBuffer read(int length, boolean preRead) throws
IOException {
return responseQueue.isEmpty() ? null : readFromQueue();
}
+ refreshReadDeadline();
Review Comment:
> Per-poll local budget has been replaced with a shared round-trip deadline
But what is the advantage for such change? It really makes the code much
harder to understand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
