[
https://issues.apache.org/jira/browse/HDDS-5383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wei-Chiu Chuang resolved HDDS-5383.
-----------------------------------
Fix Version/s: 1.2.0
Resolution: Fixed
> Eliminate expensive string creation in debug log messages
> ---------------------------------------------------------
>
> Key: HDDS-5383
> URL: https://issues.apache.org/jira/browse/HDDS-5383
> Project: Apache Ozone
> Issue Type: Improvement
> Reporter: Wei-Chiu Chuang
> Assignee: Ke-Yi Sung
> Priority: Trivial
> Labels: pull-request-available
> Fix For: 1.2.0
>
>
> Use IntelliJ and search with regex pattern: LOG\.debug.*toString
> I found a number of bad log message practice where string objects are created
> or concatenated regardless log level.
> Parameters passed to slf4j debug log are supposed to be O(1).
> For example,
> {code:title=KeyManagerImpl.refreshPipeline}
> } catch (IOException ioEx) {
> LOG.debug("Get containerPipeline failed for {}",
> containerIDs.toString(), ioEx);
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
