chihsuan commented on code in PR #10605: URL: https://github.com/apache/ozone/pull/10605#discussion_r3480749624
########## hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/response/s3/multipart/TestS3MultipartUploadCommitPartResponse.java: ########## @@ -0,0 +1,246 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.om.response.s3.multipart; + +import static org.assertj.core.api.Assertions.assertThat; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.assertNull; + +import java.io.IOException; +import java.util.List; +import java.util.UUID; +import org.apache.hadoop.hdds.utils.db.Table; +import org.apache.hadoop.ozone.om.helpers.OmKeyInfo; +import org.apache.hadoop.ozone.om.helpers.OmMultipartKeyInfo; +import org.apache.hadoop.ozone.om.helpers.RepeatedOmKeyInfo; +import org.apache.hadoop.ozone.om.request.OMRequestTestUtils; +import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos; +import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos.PartKeyInfo; +import org.apache.hadoop.util.Time; +import org.junit.jupiter.api.Test; + +/** + * Test multipart upload commit part response. + */ +public class TestS3MultipartUploadCommitPartResponse + extends TestS3MultipartResponse { + + @Test + public void testAddDBToBatch() throws Exception { + String volumeName = UUID.randomUUID().toString(); + String bucketName = UUID.randomUUID().toString(); + String keyName = getKeyName(); + String multipartUploadID = UUID.randomUUID().toString(); + + OMRequestTestUtils.addVolumeAndBucketToDB(volumeName, bucketName, + omMetadataManager); + createParentPath(volumeName, bucketName); + + String multipartKey = omMetadataManager + .getMultipartKey(volumeName, bucketName, keyName, multipartUploadID); + long clientId = Time.now(); + String openKey = getPartOpenKey(volumeName, bucketName, keyName, clientId); + + S3MultipartUploadCommitPartResponse s3MultipartUploadCommitPartResponse = + createCommitMPUResponse(volumeName, bucketName, keyName, + multipartUploadID, null, null, + OzoneManagerProtocolProtos.Status.OK, openKey); + + s3MultipartUploadCommitPartResponse.addToDBBatch(omMetadataManager, + batchOperation); + + omMetadataManager.getStore().commitBatchOperation(batchOperation); + + assertNull(omMetadataManager.getOpenKeyTable(getBucketLayout()).get(openKey)); + assertNotNull(omMetadataManager.getMultipartInfoTable().get(multipartKey)); + + // As no parts are created, so no entries should be there in delete table. + assertEquals(0, omMetadataManager.countRowsInTable( + omMetadataManager.getDeletedTable())); + } + + @Test + public void testAddDBToBatchWithParts() throws Exception { + + String volumeName = UUID.randomUUID().toString(); + String bucketName = UUID.randomUUID().toString(); + String keyName = getKeyName(); + String multipartUploadID = UUID.randomUUID().toString(); + + OMRequestTestUtils.addVolumeAndBucketToDB(volumeName, bucketName, + omMetadataManager); + createParentPath(volumeName, bucketName); + + String multipartKey = omMetadataManager + .getMultipartKey(volumeName, bucketName, keyName, multipartUploadID); + + S3InitiateMultipartUploadResponse s3InitiateMultipartUploadResponse = + createInitiateMPUResponse(volumeName, bucketName, keyName, + multipartUploadID); + + s3InitiateMultipartUploadResponse.addToDBBatch(omMetadataManager, + batchOperation); + + // Add some dummy parts for testing. + // Not added any key locations, as this just test is to see entries are + // adding to delete table or not. + OmMultipartKeyInfo omMultipartKeyInfo = + s3InitiateMultipartUploadResponse.getOmMultipartKeyInfo(); + + PartKeyInfo part1 = createPartKeyInfo(volumeName, bucketName, keyName, 1); + + addPart(1, part1, omMultipartKeyInfo); Review Comment: Done, calling addPartKeyInfo directly. 011f453 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
