hevinhsu commented on code in PR #10598:
URL: https://github.com/apache/ozone/pull/10598#discussion_r3522877376
##########
hadoop-ozone/integration-test/dev-support/findbugsExcludeFile.xml:
##########
@@ -16,4 +16,16 @@
limitations under the License.
-->
<FindBugsFilter>
+ <Match>
+ <Class
name="org.apache.hadoop.hdds.scm.TestRackAwarePlacement$WithRacksAndHosts"/>
+ <Bug pattern="SIC_INNER_SHOULD_BE_STATIC"/>
+ </Match>
+ <Match>
+ <Class
name="org.apache.hadoop.hdds.scm.TestRackAwarePlacement$WithRacksOnly"/>
+ <Bug pattern="SIC_INNER_SHOULD_BE_STATIC"/>
+ </Match>
+ <Match>
+ <Class
name="org.apache.hadoop.hdds.scm.TestRackAwarePlacement$WithHostsOnly"/>
+ <Bug pattern="SIC_INNER_SHOULD_BE_STATIC"/>
+ </Match>
Review Comment:
My understanding is that we can suppress this using
`@SuppressFBWarnings("SIC_INNER_SHOULD_BE_STATIC")`.
However, this annotation doesn't appear to be used elsewhere in the Ozone
project.
I previously handled a similar case with an exclude filter
([link](https://github.com/apache/ozone/blob/master/hadoop-ozone/integration-test-s3/dev-support/findbugsExcludeFile.xml)),
so I took the same approach this time by adding it to the filter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
