fapifta commented on PR #10230: URL: https://github.com/apache/ozone/pull/10230#issuecomment-4893470209
Hi @peterxcli thank you for your thorough review on these test additions. The Fake, now MockDatanodePipeline related suggestions were really great. I tried to address the review comments even in places where they were not directly added, but a similar comment matched onto the situation elsewhere in the code also. (Like rename to pipeline instead of fake, and explicitly check for the number of operations done.) I also removed the atomic key creation related test, as that is moved from the stream to S3 in an other change that affected the test. I found a flakiness with the injected failure and how it surfaces I addressed that also. I resolved all the relevant comments, except one that I would like to address directly there before we resolve, if you accept my answer there please resolve the review. Please also re-check the suggested changes once you have the time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
