adoroszlai commented on code in PR #10654: URL: https://github.com/apache/ozone/pull/10654#discussion_r3531861050
########## hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/DeletedBlockLogStateManagerImpl.java: ########## @@ -54,6 +55,9 @@ public class DeletedBlockLogStateManagerImpl private volatile Set<Long> deletingTxIDs; public static final String SERVICE_NAME = DeletedBlockLogStateManager.class.getSimpleName(); + public static final StatefulServiceDefinition<DeletedBlocksTransaction> SERVICE_DEFINITION = + new StatefulServiceDefinition<>(SERVICE_NAME, DeletedBlocksTransaction.parser()); + Review Comment: Thanks for spotting this. The other two definitions are used with subclasses of `StatefulService`, which ensures type safety. I don't know why this one is different, but now made some further change: use the definition in `loadDeletedBlocksSummary()`, which returns `DeletedBlocksTransactionSummary`, so that type mismatch is caught at compile time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
