jojochuang commented on code in PR #10595:
URL: https://github.com/apache/ozone/pull/10595#discussion_r3533995713
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/ReplicationSupervisor.java:
##########
@@ -293,16 +372,45 @@ private void decrementTaskCounter(AbstractReplicationTask
task) {
@VisibleForTesting
public void shutdownAfterFinish() throws InterruptedException {
+ scheduler.shutdown();
+ scheduler.awaitTermination(1L, TimeUnit.DAYS);
+ for (ThreadPoolExecutor tpe : volumeExecutors.values()) {
+ tpe.shutdown();
+ }
+ for (ThreadPoolExecutor tpe : volumeExecutors.values()) {
+ tpe.awaitTermination(1L, TimeUnit.DAYS);
+ }
+ volumeExecutors.clear();
executor.shutdown();
executor.awaitTermination(1L, TimeUnit.DAYS);
Review Comment:
this is the existing code. Isn't waiting for a day too extreme?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
