echonesis commented on PR #10680: URL: https://github.com/apache/ozone/pull/10680#issuecomment-4901387509
> Thanks @echonesis for the patch. > > * The changes in `TestKeyDeletingService` seem to be related to flakiness, not speed-up. > * The speed-up changes in `TestOzoneManagerLock` are also unrelated to `TestOMDbCheckpointServletInodeBasedXfer`. > > I think it would be better to split these into separate PRs. Jira issues may already exist for these. > > Before: > > ``` > [INFO] Tests run: 58, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 33.90 s -- in org.apache.hadoop.ozone.om.lock.TestOzoneManagerLock > > [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 16.90 s -- in org.apache.hadoop.ozone.om.service.TestKeyDeletingService$RequestBatching > [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 13.29 s -- in org.apache.hadoop.ozone.om.service.TestKeyDeletingService$Metrics > [INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 12.95 s -- in org.apache.hadoop.ozone.om.service.TestKeyDeletingService$Failing > [INFO] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 29.31 s -- in org.apache.hadoop.ozone.om.service.TestKeyDeletingService$Normal > [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 72.55 s -- in org.apache.hadoop.ozone.om.service.TestKeyDeletingService > > [INFO] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 129.8 s -- in org.apache.hadoop.ozone.om.TestOMDbCheckpointServletInodeBasedXfer > ``` > > After: > > ``` > [INFO] Tests run: 58, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 16.80 s -- in org.apache.hadoop.ozone.om.lock.TestOzoneManagerLock > > [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 16.91 s -- in org.apache.hadoop.ozone.om.service.TestKeyDeletingService$RequestBatching > [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 13.49 s -- in org.apache.hadoop.ozone.om.service.TestKeyDeletingService$Metrics > [INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 12.93 s -- in org.apache.hadoop.ozone.om.service.TestKeyDeletingService$Failing > [INFO] Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 34.46 s -- in org.apache.hadoop.ozone.om.service.TestKeyDeletingService$Normal > [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 77.90 s -- in org.apache.hadoop.ozone.om.service.TestKeyDeletingService > > [INFO] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 37.40 s -- in org.apache.hadoop.ozone.om.TestOMDbCheckpointServletInodeBasedXfer > ``` Thanks for pointing this out. You are right, the `TestKeyDeletingService` and `TestOzoneManagerLock` changes are unrelated to `TestOMDbCheckpointServletInodeBasedXfer`. I included them initially because I noticed they could affect GitHub Actions CI pass while working on this patch, but they should be handled separately. I will remove those unrelated changes from this PR and kept only the `TestOMDbCheckpointServletInodeBasedXfer` change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
