sreejasahithi commented on code in PR #10681:
URL: https://github.com/apache/ozone/pull/10681#discussion_r3544728977
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancer.java:
##########
@@ -357,6 +371,7 @@ public void stop() {
return;
}
LOG.info("Trying to stop ContainerBalancer in this SCM.");
+ task.recordStopReason("STOPPED_ON_SCM_STATE_CHANGE");
Review Comment:
Right an enum is much cleaner and easy to maintain.
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerTask.java:
##########
@@ -417,21 +427,59 @@ private long getCurrentIterationDuration() {
/**
* Logs the reason for stop and save configuration and stop the task.
*
- * @param stopReason a string specifying the reason for stop
+ * @param reason a string specifying the reason for stop
*/
- private void tryStopWithSaveConfiguration(String stopReason) {
+ private void tryStopWithSaveConfiguration(String reason) {
synchronized (this) {
try {
- LOG.info("Save Configuration for stopping. Reason: {}", stopReason);
+ recordStopReason(reason);
Review Comment:
Thanks for catching this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
