smengcl commented on code in PR #10710:
URL: https://github.com/apache/ozone/pull/10710#discussion_r3557555155


##########
hadoop-ozone/httpfsgateway/src/main/java/org/apache/ozone/fs/http/server/FSOperations.java:
##########
@@ -842,7 +837,7 @@ public Map execute(FileSystem fs) throws IOException {
    */
   @InterfaceAudience.Private
   public static class FSHomeDir
-      implements FileSystemAccess.FileSystemExecutor<JSONObject> {
+      implements FileSystemAccess.FileSystemExecutor<Map> {
 

Review Comment:
   These executors were FileSystemExecutor<JSONObject> and were translated 1:1 
to Map to keep this PR a behavior-preserving dependency swap. Fully 
parameterizing to Map<String, Object> is a reasonable type-safety improvement, 
but it cascades: it requires de-raw-ing all 18 executors plus the pre-existing 
raw-Map helpers several of them return (fileChecksumToJSON, xAttrNamesToJSON, 
contentSummaryToJSON, quotaUsageToJSON) and their locals. That is a broader 
rawtypes cleanup with no effect on the serialized JSON, so I am leaving it out 
of this json-simple removal and it can be done as a focused follow-up. The 
self-contained cases (the List locals and xAttrsToJSON) were already narrowed 
in earlier commits.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to