smengcl opened a new pull request, #10721: URL: https://github.com/apache/ozone/pull/10721
Generated-by: Claude Code (Opus 4.8) ## What changes were proposed in this pull request? `TestFailureHandlingByClient#testContainerExclusionWithClosedContainerException` fails intermittently with `Expecting empty but was: [Pipeline-...]` on the assertion that the client exclude list holds no pipeline IDs (seen in upstream CI on 2026-07-06, after HDDS-15605 removed the analogous datanodes assertion). The test forces a container to close and writes again, expecting a `ClosedContainerException` that adds only the container to the exclude list. Under the default `ALL_COMMITTED` watch level, a slow or unavailable follower can instead surface a WATCH `RaftRetryFailureException`. In `KeyOutputStream.handleException`, `checkForRetryFailure` returns true for that exception, so the container exclusion branch is skipped and the else branch adds the pipeline to the exclude list. That is intended client behavior, so an empty pipeline set is not an invariant for this configuration. This PR removes the `getPipelineIds().isEmpty()` assertion, consistent with how HDDS-15605 handled the datanodes case, and adds a comment explaining why the pipeline set is not an invariant here. The container ID exclusion assertion, which is the actual property under test, is retained. The change is limited to the test. ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-15823 ## How was this patch tested? Ran the test 100 times locally with 0 failures, each run confirmed to execute the method (`Tests run: 1, Failures: 0, Errors: 0`). Ran the full `TestFailureHandlingByClient` class (6 tests, 0 failures). Checkstyle clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
