guihecheng commented on pull request #2354: URL: https://github.com/apache/ozone/pull/2354#issuecomment-876091867
> Sorry for the delays in updating this patch. Just got back from numerous company holidays. In addition to adding metadata checks for factor one pipelines, I fixed the code from the previous Jiras so that closed container replication should now only require the size of the container being replicated to be available on a datanode (it does not need ratis metadata and may not need a full container size worth of space). See how `ReplicationManager#handleUnderReplicatedContainer` uses the new code. Unfortunately adding the metadata size parameter resulted in small changes to many files. Thanks @errose28 , I think the idea to remove the limit for replication on metadata size is good, and the added parameter serves the purpose well. Verified manually on the Ratis factor one case, it works well. And the overall patches LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
