neils-dev commented on a change in pull request #2375: URL: https://github.com/apache/ozone/pull/2375#discussion_r665867631
########## File path: hadoop-ozone/common/pom.xml ########## @@ -30,6 +30,21 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd";> <dependencies> + <dependency> + <groupId>io.grpc</groupId> Review comment: Thanks for reviewing this @xiaoyuyao and for your comments. On the using the ratis grpc/netty libraries, initially I wanted to use them, however they were not compatible with the OzoneManagerProtocol we are realizing and using. Works with the unshaded grpc/netty versions ( tested with 4.1.52.Final and 4.1.63.Final ) together with protoc compiler (version 2.5.0 and NOT 3.12.0) without issue. An example of the incompatibility includes the OzoneManagerProtocol interfacing with the HddsProtos with the thirdparty libraries. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
