sreejasahithi commented on PR #10708: URL: https://github.com/apache/ozone/pull/10708#issuecomment-4957159198
> Thanks for the fix! @sreejasahithi Overall LGTM. 👍 > > A couple of quick questions: > > * With the callback now updating the metric live, is reading it in both the finished and unfinished paths in `getDataMoveInfo` intentional? Before the fix, in progress stats read `sizeActuallyMovedInLatestIteration` while the metric stayed 0 until `checkIterationMoveResults()`. Now callbacks update the metric live, so both paths read `metrics.getDataSizeMovedInLatestIteration()` for a consistent view. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
