chihsuan commented on PR #10699: URL: https://github.com/apache/ozone/pull/10699#issuecomment-4958124219
Thanks for raising this! @sreejasahithi > 1. CommandLine descriptions or the --help text for both commands does not mention the HA --node-id requirement. > It would be better to add there as well. Sounds good! I updated the `--node-id` descriptions for both commands in https://github.com/apache/ozone/pull/10699/commits/e6758ff3817f0a1337cebcbce90a596ab893c07c. > 2. Should HA nodeId validation failure exit non-zero, or is exit 0 ok here? Yeah, I agree. I considered returning a non-zero value, but the existing `OMNodeDetails` validation returns exit code 0, so I kept the new validation consistent. I can change it in this PR if you prefer; otherwise, we can address exit codes consistently in a follow-up. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
