ptlrs commented on code in PR #10419:
URL: https://github.com/apache/ozone/pull/10419#discussion_r3574781102
##########
hadoop-hdds/common/src/main/resources/ozone-default.xml:
##########
@@ -1591,6 +1591,16 @@
If this is empty, no column families are compacted.
</description>
</property>
+ <property>
+ <name>ozone.om.compaction.service.bottommostlevelcompaction</name>
Review Comment:
Is this necessary? `bottommostlevelcompaction` is the original name as per
`org.rocksdb.CompactRangeOptions.BottommostLevelCompaction`.
Most importantly, searching for `bottommostlevelcompaction` brings up all
instances of it in both code and configuration in my IDE. Adding a separator
would break that.
##########
hadoop-hdds/common/src/main/resources/ozone-default.xml:
##########
@@ -1591,6 +1591,15 @@
If this is empty, no column families are compacted.
</description>
</property>
+ <property>
+ <name>ozone.om.compaction.service.bottommostlevelcompaction</name>
+ <value>0</value>
Review Comment:
I have updated the code to use `getEnum`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
