sreejasahithi commented on code in PR #10681:
URL: https://github.com/apache/ozone/pull/10681#discussion_r3576200317
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMClientProtocolServer.java:
##########
@@ -1379,14 +1379,13 @@ public ContainerBalancerStatusInfoResponseProto
getContainerBalancerStatusInfo()
.newBuilder()
.setIsRunning(false)
.build();
- } else {
-
- return ContainerBalancerStatusInfoResponseProto
- .newBuilder()
- .setIsRunning(true)
- .setContainerBalancerStatusInfo(balancerStatusInfo.toProto())
- .build();
}
+
+ return ContainerBalancerStatusInfoResponseProto
+ .newBuilder()
+ .setIsRunning(scm.getContainerBalancer().isBalancerRunning())
Review Comment:
yes this is better as using getShouldRun() from the already captured info
ensures both fields in the response are always consistent with each other.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
