peterxcli commented on PR #10751: URL: https://github.com/apache/ozone/pull/10751#issuecomment-4966374452
> If we remove review_on_push: true, we get initial review, but need to request follow-up manually. Why not make all reviews manual in that case? actually I'm not really sure what would happend(all manually or review on opening) if the copilot is enable and review_on_push is disable > I also find copilot review annoying, so I would be totally fine removing it completely. But others find it useful and discussed using it. so keep it to review on demand would be the consensus. > I did not get any copilot review on my PRs (https://github.com/apache/ozone/pull/10730, https://github.com/apache/ozone/pull/10738, https://github.com/apache/ozone/pull/10739). Not sure why, maybe it needs to be enabled in personal settings? I also have no idea. > In any case, we should keep review_drafts: true, to avoid unnecessary CI. good point, added it back > Please make sure to reflect the change in the title. Also, what does [1/2] mean? ok, the original "[1/2]" means this is the patch for the same [HDDS-15692](https://issues.apache.org/jira/browse/HDDS-15692) ticket which https://github.com/apache/ozone/pull/10705 is the first PR of it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
