[GitHub] [ozone] pakapoj-tul commented on a change in pull request #2343: HDDS-5193. change to use getShortUserName instead of getUsername

Thu, 08 Jul 2021 22:40:42 -0700 


pakapoj-tul commented on a change in pull request #2343:
URL: https://github.com/apache/ozone/pull/2343#discussion_r666684427



##########
File path: 
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java
##########
@@ -541,7 +541,7 @@ private static void verifySpaceQuota(long quota) throws 
OMException {
    * @return listOfAcls
    * */
   private List<OzoneAcl> getAclList() {
-    return OzoneAclUtil.getAclList(ugi.getUserName(), ugi.getGroupNames(),
+    return OzoneAclUtil.getAclList(ugi.getShortUserName(), ugi.getGroupNames(),

Review comment:
       Hi, seem to be very odd if the ACL was set using authenticated user ugi.
   <img width="1550" alt="Screen Shot 2564-07-09 at 11 21 00" 
src="https://user-images.githubusercontent.com/71322162/125028591-84198e80-e0b2-11eb-996b-4685c6835b66.png";>
   My thoughts was if we have `data_pipeline` user as a writer who write data 
to `/vol1/bucket1/mykey` and `data_sci` as a reader who read data at 
`/vol1/bucket1/mykey` , we have to reassign `/vol1/bucket1/mykey` acl  = 
`/vol1/bucket1/`  anyway…




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to