jojochuang commented on PR #489: URL: https://github.com/apache/ozone-site/pull/489#issuecomment-4974778069
## Bugbot review Reviewed `HDDS-15767-remove-pull-rep-docs` against `master` (internals replication doc update after pull replication removal). **3 findings:** | Severity | Location | Finding | |----------|----------|---------| | Medium | `docs/05-administrator-guide/02-configuration/99-appendix.md:262` | Contradictory documentation: the updated internals page states Ozone uses push replication only, but the configuration appendix still documents `hdds.scm.replication.push` and describes pull mode when set to `false`. Either update the appendix in the same change (or a paired `ozone-default.xml` regen), or soften the internals claim (e.g. push is default/recommended) and cross-link the config key. | | Low | `docs/07-system-internals/04-replication/02-data/02-containers/08-replication.md:45` | Wrong actor in Step 2: under "Destination Datanode Receives Tarball," the bullet says the destination "parallelizes container **upload**." In push replication the source uploads; the destination receives/ingests. | | Low | `docs/07-system-internals/04-replication/02-data/02-containers/08-replication.md:77` | Leftover pull terminology: Step 5 still refers to "The **downloaded** tarball," which conflicts with the push-only framing elsewhere on the page. Prefer "received" or "streamed." | **Notes (not raised as bugs):** - The removed EC "Under-Replication" scenario (master had four EC scenarios; this branch has three) may be intentional if under-replication is handled by reconstruction rather than container copy—worth confirming in the PR description. - `versioned_docs/version-2.1.0` and `2.1.1` still document pull replication; that is expected for frozen release snapshots unless this release also versions docs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
