Copilot commented on code in PR #10770:
URL: https://github.com/apache/ozone/pull/10770#discussion_r3584633419
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/snapshot/TestSnapshotDiffManager.java:
##########
@@ -223,6 +223,8 @@ public static void initCodecRegistry() {
codecRegistry = CodecRegistry.newBuilder()
.addCodec(DiffReportEntry.class, getDiffReportEntryCodec())
.addCodec(SnapshotDiffJob.class, SnapshotDiffJob.codec())
+ .addCodec(OmKeyInfo.class, OmKeyInfo.getKeyTableCodec())
+ .addCodec(OmDirectoryInfo.class, OmDirectoryInfo.getCodec())
Review Comment:
The snap diff CodecRegistry setup is being extended to include
OmKeyInfo/OmDirectoryInfo, but there’s no regression check that the registry
can actually serialize/deserialize these types. Adding a small round-trip
sanity check here would ensure future changes don’t reintroduce the
IllegalStateException that this PR is addressing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
