Gargi-jais11 commented on code in PR #10755:
URL: https://github.com/apache/ozone/pull/10755#discussion_r3585185614
##########
hadoop-ozone/cli-admin/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DatanodeParameters.java:
##########
@@ -43,10 +43,11 @@ public class DatanodeParameters extends ItemsFromStdin {
" # From file having list of dns to balance",
" ozone admin datanode diskbalancer report - < datanode-lists.txt",
"Port is optional and defaults to 19864 (CLIENT_RPC port).",
- "Address examples: 'DN-1', 'DN-1:19864', '192.168.1.10'."
+ "Address examples: 'DN-1', 'DN-1:19864', '192.168.1.10',",
+ " 'a3b63511-bdf8-4fa1-8ab6-d19c0e806f84' (datanode UUID)."
},
arity = "0..*",
- paramLabel = "<datanode address>")
+ paramLabel = "<datanode address or id>")
Review Comment:
no need of explicit -id flag here. Positional behaviour is intentional
because there are other commands as well whcih simply gets dn hostname/
ipaddress / uuid without explicit flag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
