sodonnel commented on a change in pull request #2335:
URL: https://github.com/apache/ozone/pull/2335#discussion_r667009300
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/pipeline/Pipeline.java
##########
@@ -443,7 +443,7 @@ public static Builder newBuilder(Pipeline pipeline) {
return new Builder(pipeline);
}
- private void setReplicaIndexes(Map<DatanodeDetails, Integer> replicaIndexes)
{
+ public void setReplicaIndexes(Map<DatanodeDetails, Integer> replicaIndexes) {
Review comment:
I think this should remain private to keep Pipeline immutable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
