dombizita commented on code in PR #9723:
URL: https://github.com/apache/ozone/pull/9723#discussion_r3602791601
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -1682,37 +1682,58 @@ message FinalizeUpgradeProgressResponse {
required hadoop.hdds.UpgradeFinalizationStatus status = 1;
}
+/**
+ * Deprecated. Prepare functionality has been removed.
+ */
message PrepareRequest {
- required PrepareRequestArgs args = 1;
+ required PrepareRequestArgs args = 1 [deprecated = true];
}
+/**
+ * Deprecated. Prepare functionality has been removed and is now a no-op.
+ */
message PrepareRequestArgs {
- optional uint64 txnApplyWaitTimeoutSeconds = 1 [default = 300];
- optional uint64 txnApplyCheckIntervalSeconds = 2 [default = 5];
+ optional uint64 txnApplyWaitTimeoutSeconds = 1 [default = 300, deprecated
= true];
+ optional uint64 txnApplyCheckIntervalSeconds = 2 [default = 5, deprecated
= true];
}
+/**
+ * Deprecated. Prepare functionality has been removed and is now a no-op.
+ */
message PrepareResponse {
- required uint64 txnID = 1;
+ required uint64 txnID = 1 [deprecated = true];
}
+/**
+ * Deprecated. Prepare functionality has been removed and is now a no-op.
+ */
message PrepareStatusRequest {
- required uint64 txnID = 1;
+ required uint64 txnID = 1 [deprecated = true];
}
+/**
+ * Deprecated. Prepare functionality has been removed and server status will
always be NOT_PREPARED.
Review Comment:
```suggestion
* Deprecated. Prepare functionality has been removed and server status will
always be PREPARE_COMPLETED.
```
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OmUtils.java:
##########
@@ -263,6 +263,9 @@ public static boolean isReadOnly(OMRequest omRequest) {
return true;
case GetQuotaRepairStatus:
case StartQuotaRepair:
+ // Prepare and CancelPrepare are now no-ops, but still produce responses
for compatability.
+ case Prepare:
+ case CancelPrepare:
Review Comment:
nit: why moving it up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
