Copilot commented on code in PR #10790:
URL: https://github.com/apache/ozone/pull/10790#discussion_r3605495212
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/upgrade/TestScmHAFinalization.java:
##########
@@ -88,6 +89,14 @@ public void init(OzoneConfiguration conf,
conf.setInt(SCMStorageConfig.TESTING_INIT_LAYOUT_VERSION_KEY,
HDDSLayoutFeature.INITIAL_VERSION.layoutVersion());
conf.set(ScmConfigKeys.OZONE_SCM_HA_RATIS_SERVER_RPC_FIRST_ELECTION_TIMEOUT,
"5s");
+ conf.set(HddsConfigKeys.HDDS_SCM_SAFEMODE_RULE_REFRESH_INTERVAL, "0s");
+ conf.setTimeDuration(ScmConfigKeys.OZONE_SCM_HEARTBEAT_PROCESS_INTERVAL,
100, TimeUnit.MILLISECONDS);
+ conf.setTimeDuration(HddsConfigKeys.HDDS_HEARTBEAT_INTERVAL, 100,
TimeUnit.MILLISECONDS);
+ conf.setTimeDuration(HddsConfigKeys.HDDS_PIPELINE_REPORT_INTERVAL, 100,
TimeUnit.MILLISECONDS);
Review Comment:
The PR description says that after SCM restart the test now waits for the
leader to reach FINALIZATION_COMPLETE (via waitForScmToFinalize()) before
polling the client in waitForFinalizationFromClient(). In the current diff,
testFinalizationWithRestart() still goes directly from
cluster.waitForClusterToBeReady() to waitForFinalizationFromClient(), so the
described flakiness fix is not reflected in the code changes. Please either add
the missing wait in the restart test (as described) or update the PR
description/test plan to match what is actually changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
