chungen0126 commented on code in PR #20:
URL: https://github.com/apache/ozone-helm-charts/pull/20#discussion_r3619734581


##########
charts/ozone/templates/om/om-statefulset.yaml:
##########
@@ -39,25 +40,45 @@ spec:
   template:
     metadata:
       annotations:
-        checksum/config: {{ include (print $.Template.BasePath 
"/ozone-configmap.yaml") . | sha256sum }}
+        checksum/config: {{ include (print $.Template.BasePath 
"/ozone-configmap.yaml") . | cat (include "ozone.configuration.env" .) | 
sha256sum }}
       labels:
         {{- include "ozone.selectorLabels" . | nindent 8 }}
         app.kubernetes.io/component: om
     spec:
+      {{- if and .Values.om.persistence.enabled (gt (len $bnodes) 0) }}

Review Comment:
   Based on our offline discussion with @shuan1026 , we noticed that leader 
transfers take a long time. The reason is that after operating a transfer, the 
node relies on the logs appended from new leader to confirm whether the 
transfer succeeded. 
   
   However, under the current setup, an address is only exposed to DNS when the 
pod is ready. We should set publishNotReadyAddresses to true to expose unready 
addresses as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to