spacemonkd commented on code in PR #10577:
URL: https://github.com/apache/ozone/pull/10577#discussion_r3629489077
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/v2/pages/overview/overview.tsx:
##########
@@ -172,7 +172,7 @@ const Overview: React.FC<{}> = () => {
openContainers,
omServiceId,
scmServiceId
- } = clusterState.data;
+ } = clusterState.data ?? {};
Review Comment:
I agree with this.
Currently we do not have a standard of the HTTP code vs the response.
For example and empty body should have given an error code instead of a 200.
I think it is better to use `DEFAULT_CLUSTER_STATE` as the fallback. But
yeah, sometime down the line we are planning to separate out error state vs
unknown states
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
