yandrey321 commented on PR #10828: URL: https://github.com/apache/ozone/pull/10828#issuecomment-5048957504
> > This solution creates a race condition, ... > > What is the race condition? > > > ... Changes in this PR allows graceful fail back to non-stream writes. > > The change in this PR is very complicated. It does not worth to implement fallback for just changing the conf from disable streaming to enable streaming. here is the part for re-creating pipelines when streaming is enabled: https://github.com/apache/ozone/pull/10842/ without client side fix (changes in the current PR) the part 2 fails with the following error on writing files after enabling the streaming: ``` mvn -pl hadoop-ozone/integration-test test \ -Dtest='TestOzoneFileSystemDataStreamEnablement#testBatchWritesAcrossStreamingEnablement' \ -DskipShade -DskipRecon \ -Ddevelocity.cache.local.enabled=false -Ddevelocity.cache.remote.enabled=false -Dscan=false Tests run: 1, Failures: 0, Errors: 1 <<< FAILURE! java.io.IOException: RATIS_DATASTREAM port is missing for datanode <dn> in pipeline <id>; datastream is disabled for this pipeline at org.apache.hadoop.ozone.client.io.KeyDataStreamOutput.handleWrite(KeyDataStreamOutput.java:212) ... Caused by: java.io.IOException: RATIS_DATASTREAM port is missing ... at org.apache.hadoop.hdds.scm.storage.BlockDataStreamOutput.setupStream(BlockDataStreamOutput.java:200) at org.apache.hadoop.hdds.scm.storage.BlockDataStreamOutput.<init>(BlockDataStreamOutput.java:173) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
