spacemonkd commented on code in PR #10062:
URL: https://github.com/apache/ozone/pull/10062#discussion_r3633388419
##########
hadoop-ozone/common/src/test/java/org/apache/hadoop/ozone/om/helpers/TestOmMultipartPartInfo.java:
##########
@@ -63,6 +63,7 @@ public void testGetFromProtoRejectsMissingRequiredFields() {
() ->
OmMultipartPartInfo.getFromProto(base.toBuilder().clearPartName().build()));
assertThrows(IllegalArgumentException.class,
() ->
OmMultipartPartInfo.getFromProto(base.toBuilder().clearPartNumber().build()));
+ // Behaviour change: eTag is now a mandatory field for all clients.
Review Comment:
Thanks @errose28 for pointing this out. Yeah I missed out on these comments
in the tests, claude has been a bit eager with the notes.
Addressed in the latest commit!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
