dombizita commented on code in PR #10817:
URL: https://github.com/apache/ozone/pull/10817#discussion_r3636103544
##########
hadoop-hdds/interface-server/src/main/proto/ScmServerDatanodeHeartbeatProtocol.proto:
##########
@@ -498,13 +515,26 @@ message ProcessCRLCommandProto {
/**
* This command asks the DataNode to finalize a new layout version.
+ *
+ * Deprecated, please use FinalizeNewDatanodeVersionCommandProto instead, which
+ * carries a DatanodeVersionProto instead of the deprecated LayoutVersionProto.
*/
message FinalizeNewLayoutVersionCommandProto {
required bool finalizeNewLayoutVersion = 1 [default = false];
required LayoutVersionProto dataNodeLayoutVersion = 2;
required int64 cmdId = 3;
}
+/**
+ * This command asks the DataNode to finalize a new datanode version.
+ * Replaces FinalizeNewLayoutVersionCommandProto.
+ */
+message FinalizeNewDatanodeVersionCommandProto {
+ required bool finalizeNewDatanodeVersion = 1 [default = false];
+ optional DatanodeVersionProto datanodeVersion = 2;
Review Comment:
With the latest patch it is using expected software version field, which is
set based on the SCM's software version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
