ChenSammi commented on a change in pull request #2397:
URL: https://github.com/apache/ozone/pull/2397#discussion_r668470533



##########
File path: hadoop-ozone/dist/src/main/smoketest/admincli/datanode.robot
##########
@@ -34,6 +34,14 @@ Filter list by UUID
     ${count} =          Get Length   ${lines}
     Should Be Equal As Integers    ${count}    1
 
+Filter list by NodeOperationalState
+    ${output} =         Execute      ozone admin datanode list 
--NodeOperationalState IN_SERVICE
+    Should contain      ${output}    Datanode:

Review comment:
       Can you add a datanode UUID to the "Datanode:" string ? 

##########
File path: hadoop-ozone/dist/src/main/smoketest/admincli/datanode.robot
##########
@@ -34,6 +34,14 @@ Filter list by UUID
     ${count} =          Get Length   ${lines}
     Should Be Equal As Integers    ${count}    1
 
+Filter list by NodeOperationalState
+    ${output} =         Execute      ozone admin datanode list 
--NodeOperationalState IN_SERVICE
+    Should contain      ${output}    Datanode:
+
+Filter list by NodeState
+    ${output} =         Execute      ozone admin datanode list --NodeState 
HEALTHY
+    Should contain      ${output}    Datanode:

Review comment:
       Same as above

##########
File path: hadoop-ozone/dist/src/main/smoketest/admincli/datanode.robot
##########
@@ -34,6 +34,14 @@ Filter list by UUID
     ${count} =          Get Length   ${lines}
     Should Be Equal As Integers    ${count}    1
 
+Filter list by NodeOperationalState
+    ${output} =         Execute      ozone admin datanode list 
--NodeOperationalState IN_SERVICE
+    Should contain      ${output}    Datanode:
+
+Filter list by NodeState
+    ${output} =         Execute      ozone admin datanode list --NodeState 
HEALTHY
+    Should contain      ${output}    Datanode:

Review comment:
       Same as above.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to