jojochuang commented on PR #10693: URL: https://github.com/apache/ozone/pull/10693#issuecomment-5074587163
Thanks for the re-review on **`dd86227`**, @smengcl. Several of your Jul 10 threads are already in that commit (**`3e2b277`**, **`7c2df931`**): - **Volume failure / `shutdownNow`:** drained queued `TaskRunner`s → `cancelDrainedTaskRunners` (`volumeFailureCleansUpQueuedTasks`). - **`setPerVolumePoolSize`:** `replicationConfig` + `resize(state.get())`. - **`isPushReplication`:** removed (HDDS-15614). - **Submit race:** `RejectedExecutionException` → `rollbackQueuedTask` (message-only log). - **Failed-volume push:** global pool fallback ([HDDS-15327](https://issues.apache.org/jira/browse/HDDS-15327)); described in PR text. **Follow-up commit [`28798f`](https://github.com/apache/ozone/pull/10693/commits/28798f16cc856a06cc35549dde26b5a277d5c755)** (Jul 24 Copilot + config/metrics items): - **`assertTrue(await…)`** in isolation / volume-failure tests (r3574445615). - **Thread names:** full volume path via custom `ThreadFactory` (replacing leaf-only `getName()` from fb242; r3574530906). - **Config + Decommission docs:** `streams.limit` vs `per.volume.streams.limit` split, disk-bound / effective concurrency; default **`per.volume.streams.limit=2`**. - **`maxReplicationStreams`:** description = global executor only; aggregate / per-volume capacity gauges tracked as a fast follower in [HDDS-15615](https://issues.apache.org/jira/browse/HDDS-15615). Happy to adjust scope on HDDS-15615 if you prefer a different split. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
