sodonnel commented on pull request #2377: URL: https://github.com/apache/ozone/pull/2377#issuecomment-879007921
Thanks for addressing the review comments @ChenSammi. I think this change looks better now. I just have one more comment inline where you are getting the nodeStatus - I think you should call the existing NodeManager API to get it so it is all protected under a lock. > Removing the dead dn from topology seems a good idea. I think we should do that part under a separate Jira as its a slightly different change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
