yandrey321 commented on code in PR #10865:
URL: https://github.com/apache/ozone/pull/10865#discussion_r3668069859
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/RatisPipelineProvider.java:
##########
@@ -224,18 +217,39 @@ public Pipeline createForRead(
.build();
}
- private List<DatanodeDetails> filterPipelineEngagement() {
+ private List<DatanodeDetails> chooseThreeFactorDatanodes(
+ List<DatanodeDetails> excludedNodes, List<DatanodeDetails> favoredNodes,
int requiredNode)
+ throws IOException {
final NodeManager nodeManager = getNodeManager();
final PipelineStateManager stateManager = getPipelineStateManager();
final List<DatanodeDetails> healthyNodes =
nodeManager.getNodes(NodeStatus.inServiceHealthy());
- final List<DatanodeDetails> excluded = new ArrayList<>();
+ excludedNodes = excludedNodes.isEmpty() ? new ArrayList<>() :
excludedNodes;
+ List<DatanodeDetails> strictExcludedNodes = null;
for (DatanodeDetails d : healthyNodes) {
final int count =
PipelinePlacementPolicy.currentRatisThreePipelineCount(nodeManager,
stateManager, d);
if (count >= nodeManager.pipelineLimit(d)) {
- excluded.add(d);
+ excludedNodes.add(d);
+ } else if (!d.hasPort(RATIS_DATASTREAM)) {
Review Comment:
we need to prioritize nodes with datastream port only if data stream feature
is enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
