jojochuang commented on PR #10363: URL: https://github.com/apache/ozone/pull/10363#issuecomment-5108789684
Revived with updated test logic on branch [`jojochuang:HDDS-15209`](https://github.com/jojochuang/ozone/tree/HDDS-15209) (commit `7fc35c`). Addresses review feedback: - **@SaketaChalamchala:** Expected diffs are built from snapshot SST metadata (`buildNonDagMetadataDiff`, cross-checked against `getSSTDiffList(..., useCompactionDag=false)`). DAG-mode `getSSTDiffList` is checked via column-family subset filtering against the full-table DAG diff (not by reusing the same DAG call as the oracle). SST backup checks use first→last diff vs last snapshot or backup dir (no fixed count / SST ids). - **Copilot:** Fail fast when `getSSTDiffList(..., true)` returns empty `Optional`; wait for in-flight compactions before assertions. If the original PR head should stay on `arunsarin85/HDDS-15209`, cherry-pick `7fc35c5832a` there; happy to align branches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
