fmorg-git commented on code in PR #10875:
URL: https://github.com/apache/ozone/pull/10875#discussion_r3669853583
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3sts/S3STSEndpoint.java:
##########
@@ -128,35 +148,37 @@ public Response get(
@QueryParam("Version") String version,
@QueryParam("Policy") String awsIamSessionPolicy) throws OS3Exception {
- return handleSTSRequest(action, roleArn, roleSessionName, durationSeconds,
version, awsIamSessionPolicy);
+ return handleSTSRequest(
+ getQueryParameters().keySet(), action, roleArn, roleSessionName,
durationSeconds, version, awsIamSessionPolicy);
}
/**
* STS endpoint that handles POST requests with form data.
* AWS STS typically uses POST requests with form-encoded parameters.
*
- * @param action The STS action to perform
- * @param roleArn The ARN of the role to assume
- * @param roleSessionName Session name for the role
- * @param durationSeconds Duration of the token validity
- * @param version AWS STS API version
+ * @param form form-encoded request parameters
* @return Response containing STS response XML or error
*/
@POST
+ @Consumes(MediaType.APPLICATION_FORM_URLENCODED)
Review Comment:
per my investigation, AWS STS and IAM strictly use the AWS Query Protocol
(which has `application/x-www-form-urlencoded` as the content type). Only
newer services like Amazon Cognito, Amazon DynamoDB, Amazon SQS, etc support
AWS JSON RPC 1.1. (not sure if you saw SQS and thought it was STS).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
