[
https://issues.apache.org/jira/browse/HDDS-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Attila Doroszlai resolved HDDS-16010.
-------------------------------------
Resolution: Fixed
> Website linting is silently failing
> -----------------------------------
>
> Key: HDDS-16010
> URL: https://issues.apache.org/jira/browse/HDDS-16010
> Project: Apache Ozone
> Issue Type: Bug
> Reporter: Ethan Rose
> Assignee: Ethan Rose
> Priority: Major
> Labels: pull-request-available
>
> Since HDDS-14546, CI has been passing even with lint errors because {{pnpm
> run lint}} always returns 0. It is defined as
> {code}
> "lint": "eslint . ; markdownlint . ; yamllint --format=colored ."
> {code}
> Claude's explanation which is more thorough than mine:
> The three tools are chained with ;, not &&. In a shell, a ;-separated
> sequence returns the exit code of the last command only. So:
> * eslint fails → non-zero code, but ignored; next command runs anyway.
> * markdownlint fails → non-zero code, but ignored; next command runs anyway.
> * The overall exit code of pnpm run lint = whatever yamllint returns.
> So unless yamllint itself fails, the Run lint step exits 0 and CI stays green
> — even with eslint or markdownlint errors present. markdownlint is genuinely
> running (you'd see its errors in the log output), but its failure is
> swallowed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
