chihsuan commented on code in PR #10892:
URL: https://github.com/apache/ozone/pull/10892#discussion_r3674322761
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerTask.java:
##########
@@ -635,7 +636,7 @@ private boolean initializeIteration() {
selectionCriteria = new ContainerBalancerSelectionCriteria(config,
nodeManager, replicationManager, containerManager, findSourceStrategy,
- containerToSourceMap);
+ containerToSourceMap, excludeContainersDueToFailure);
Review Comment:
`REPLICATION_NOT_HEALTHY_AFTER_MOVE` may be temporary or target-specific.
Would it make sense to persist only the `ContainerNotFoundException` exclusions
across iterations, and keep the transient ones iteration-scoped?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
