shuan1026 opened a new pull request, #53:
URL: https://github.com/apache/ozone-helm-charts/pull/53
## What changes were proposed in this pull request?
`charts/ozone/values.yaml` listed several `helm.*` keys that templates never
consumed. Users could set them and reasonably expect an effect; nothing
happened. This change aligns values with real behavior.
### Wire (keep + consume)
* `helm.resources` and `helm.podAnnotations` are now applied to both
helm-manager Jobs:
* `om-leader-transfer-job` (`pre-upgrade`)
* `om-decommission-job` (`post-upgrade`)
* Use same pattern used by OM/SCM/DN/S3G StatefulSets.
### Remove (unused + misleading)
* Drop unused `helm.persistence` keys that never had template consumers:
`enabled`, `accessModes`, `size`, `storageClassName`.
* Remove the comment claiming helm-manager persistence is enabled
automatically when datanode/scm/om persistence is on (that logic does not
exist).
* Fix SCM copy-paste comments on `helm.resources` / `helm.podAnnotations`.
### Keep
* `helm.persistence.path` — still used to build `HELM_MANAGER_PATH` for the
OM bootstrap stamp.
## Why no dedicated helm-manager PVC?
Helm Manager is not a long-running workload. It is ephemeral Helm hook Jobs
(`pre-upgrade` leader-transfer, `post-upgrade` decommission; deleted after
`hook-succeeded` / `hook-failed`). They do not own durable storage:
* Decommission mounts the **existing OM PVC** to wipe content.
* The bootstrap stamp is written on the **OM volume**, not a helm-manager
volume.
So `enabled` / `accessModes` / `size` / `storageClassName` had nothing to
attach to and implied a PVC API the chart never implemented.
## Why keep `helm.persistence.path`?
`path` is not a PVC knob. It only names a **subdirectory under the OM
volume** for chart-managed markers:
```text
HELM_MANAGER_PATH = om.persistence.path + helm.persistence.path
default: /data + /data → /data/data
stamp file: /data/data/bootstrapped
```
The OM bootstrap initContainer uses that path so the stamp stays next to OM
data but outside the Ozone metadata tree. Deleting `path` would break (or force
hard-coding of) that layout; keeping it is intentional and documented in the
values comment.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15993
## How was this patch tested?
* Grep: removed persistence keys absent; `resources` / `podAnnotations`
referenced from both Job templates; `helm.persistence.path` still used by
bootstrap ConfigMap
* kind smoke: persistence + scale-down still works
* Green CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
