adoroszlai commented on a change in pull request #2410: URL: https://github.com/apache/ozone/pull/2410#discussion_r669695030
########## File path: hadoop-ozone/interface-client/pom.xml ########## @@ -63,6 +63,59 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd";> </protocArtifact> </configuration> </execution> + <execution> + <id>compile-protoc3</id> + <goals> + <goal>compile</goal> + <goal>test-compile</goal> + </goals> + <configuration> + <protoSourceRoot>${basedir}/src/main/proto/</protoSourceRoot> + <protocArtifact> + com.google.protobuf:protoc:${proto3.hadooprpc.protobuf.version}:exe:${os.detected.classifier} + </protocArtifact> + <outputDirectory>target/generated-sources/protobuf/java/proto3</outputDirectory> + <clearOutputDirectory>false</clearOutputDirectory> + </configuration> + </execution> + </executions> + </plugin> + <plugin> + <artifactId>maven-antrun-plugin</artifactId> + <executions> + <execution> + <phase>generate-sources</phase> + <configuration> + <tasks> + <replace token="com.google.protobuf" + value="org.apache.hadoop.thirdparty.protobuf" + dir="target/generated-sources/protobuf/java/proto3/org/apache/hadoop/ozone/protocol/proto"> + </replace> + <replace token="com.google.protobuf" + value="org.apache.hadoop.thirdparty.protobuf" + dir="target/generated-sources/protobuf/java/proto3/org/apache/hadoop/ozone/security/proto"> + </replace> + <replace token="org.apache.hadoop.ozone.protocol.proto" + value="org.apache.hadoop.ozone.protocol.proto3" + dir="target/generated-sources/protobuf/java/proto3/org/apache/hadoop/ozone/protocol/proto"> Review comment: In addition to renaming the package, I think the files should be moved to `org/apache/hadoop/ozone/protocol/proto3`. Something like this in the Ant task: ``` <move file="target/generated-sources/java/proto3/org/apache/hadoop/hdds/protocol/proto" tofile="target/generated-sources/java/proto3/org/apache/hadoop/hdds/protocol/proto3"/> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
