errose28 commented on PR #10889: URL: https://github.com/apache/ozone/pull/10889#issuecomment-5144757880
I had wrapped the `SCMStateMachine` in try-with-resources to address a warning. Although the `SCMStateMachine` instance is a real object, its contents are mocked. This was causing the NPE when `SCMStateMachine#close` was invoked, since it is trying to do clean up on the mocks. I added a comment explaining this. Mocking the nested fields so `close` succeeds is fragile. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
