szetszwo commented on code in PR #10907:
URL: https://github.com/apache/ozone/pull/10907#discussion_r3691648101
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/response/snapshot/TestOMSnapshotMoveTableKeysResponse.java:
##########
@@ -128,9 +128,9 @@ public void testMoveTableKeysToNextSnapshot(boolean
nextSnapshotExists) throws E
getVolumeName(), getBucketName(), snapshotName1);
UncheckedAutoCloseableSupplier<OmSnapshot> snapshot2 =
nextSnapshotExists ? getOmSnapshotManager().getSnapshot(
getVolumeName(), getBucketName(), snapshotName2) : null) {
- List<List<String>> expectedSnapshotIdLocks =
-
Arrays.asList(Collections.singletonList(snapshot1.get().getSnapshotID().toString()),
- nextSnapshotExists ?
Collections.singletonList(snapshot2.get().getSnapshotID().toString()) : null);
+ final List<String> first =
Collections.singletonList(snapshot1.get().getSnapshotID().toString());
Review Comment:
Let's focus on the non-whitespace characters, especially for the tests; see
https://en.wikipedia.org/wiki/Law_of_triviality 😀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
