spacemonkd commented on code in PR #10919:
URL: https://github.com/apache/ozone/pull/10919#discussion_r3695965528
##########
hadoop-ozone/interface-storage/src/main/java/org/apache/hadoop/ozone/om/lock/IOzoneManagerLock.java:
##########
@@ -26,34 +26,52 @@
*/
public interface IOzoneManagerLock {
- OMLockDetails acquireReadLock(Resource resource,
- String... resources);
+ // ---------- acquireReadLock ----------
+ OMLockDetails acquireReadLock(Resource resource, String key);
+
+ OMLockDetails acquireReadLock(Resource resource, String key1, String key2);
+
+ OMLockDetails acquireReadLock(Resource resource, String... keys);
OMLockDetails acquireReadLocks(Resource resource, Iterable<String[]> keys);
- OMLockDetails acquireWriteLock(Resource resource,
- String... resources);
+ // ---------- acquireWriteLock ----------
+ OMLockDetails acquireWriteLock(Resource resource, String key);
+
+ OMLockDetails acquireWriteLock(Resource resource, String key1, String key2);
+
+ OMLockDetails acquireWriteLock(Resource resource, String... keys);
Review Comment:
Nit: Same as above, a documenting comment for the precondition check would
be good to have.
##########
hadoop-ozone/interface-storage/src/main/java/org/apache/hadoop/ozone/om/lock/IOzoneManagerLock.java:
##########
@@ -26,34 +26,52 @@
*/
public interface IOzoneManagerLock {
- OMLockDetails acquireReadLock(Resource resource,
- String... resources);
+ // ---------- acquireReadLock ----------
+ OMLockDetails acquireReadLock(Resource resource, String key);
+
+ OMLockDetails acquireReadLock(Resource resource, String key1, String key2);
+
+ OMLockDetails acquireReadLock(Resource resource, String... keys);
OMLockDetails acquireReadLocks(Resource resource, Iterable<String[]> keys);
- OMLockDetails acquireWriteLock(Resource resource,
- String... resources);
+ // ---------- acquireWriteLock ----------
+ OMLockDetails acquireWriteLock(Resource resource, String key);
+
+ OMLockDetails acquireWriteLock(Resource resource, String key1, String key2);
+
+ OMLockDetails acquireWriteLock(Resource resource, String... keys);
OMLockDetails acquireWriteLocks(Resource resource, Iterable<String[]> keys);
OMLockDetails acquireResourceWriteLock(Resource resource);
+ // ---------- MultiUserLock ----------
boolean acquireMultiUserLock(String firstUser, String secondUser);
void releaseMultiUserLock(String firstUser, String secondUser);
- OMLockDetails releaseWriteLock(Resource resource,
- String... resources);
+ // ---------- releaseWriteLock ----------
+ OMLockDetails releaseWriteLock(Resource resource, String key);
+
+ OMLockDetails releaseWriteLock(Resource resource, String key1, String key2);
+
+ OMLockDetails releaseWriteLock(Resource resource, String... keys);
Review Comment:
Same nit here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
