jojochuang commented on code in PR #522:
URL: https://github.com/apache/ozone-site/pull/522#discussion_r3717398854


##########
docs/05-administrator-guide/03-operations/09-observability/06-distributed-tracing.md:
##########
@@ -96,6 +122,49 @@ export 
OTEL_SPAN_SAMPLING_ARG="createVolume:1.0,getBucket:0.5"
 
 > **Note:** In this example, 100% of `createVolume` spans and 50% of 
 > `getBucket` spans will be collected.
 
+## Instrumented Components
+
+When tracing is enabled, specific services emit spans using the designated 
identifiers below.
+Trace context is propagated across service boundaries via gRPC and W3C context 
propagation.
+
+| Service / Component       | Service Name |
+|---------------------------| ------------ |
+| Ozone Manager             | `OzoneManager` |
+| Storage Container Manager | `StorageContainerManager` |
+| Datanode                  | `HddsDatanodeService.{datanodeId}` |
+| S3 Gateway                | `S3gateway` |
+| Ozone Client              | `client` |

Review Comment:
   client only applies when Ozone owns the SDK and initializes tracing before 
anything else in the JVM.
   
   Let's say HBase RegionServer initializes open telemetry and then access 
Ozone via ozone file system API, it would export traces using service name 
'HBase'



##########
docs/05-administrator-guide/03-operations/09-observability/06-distributed-tracing.md:
##########
@@ -8,7 +8,7 @@ Distributed tracing can help to understand performance 
bottleneck with visualizi
 Ozone makes use of [OpenTelemetry](https://opentelemetry.io/) API for tracing 
and uses OTLP with gRPC format for sending traces.
 [jaeger](https://jaegertracing.io) tracing library as collector can collect 
traces from Ozone over default port 4317 (as default).
 
-## Enabling Tracing
+## Enabling Tracing {#enabling-tracing}

Review Comment:
   this change is not needed. Docusaurus automatically creates section links.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to