smengcl commented on code in PR #10951:
URL: https://github.com/apache/ozone/pull/10951#discussion_r3740277135
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/snapshot/TestOmSnapshotCheckpointDbContent.java:
##########
@@ -110,7 +110,8 @@ private void startCluster() throws Exception {
conf = new OzoneConfiguration();
conf.setBoolean(OZONE_FILESYSTEM_SNAPSHOT_ENABLED_KEY, true);
- conf.setInt(OZONE_SNAPSHOT_DEFRAG_SERVICE_INTERVAL, 7200);
+ // Disable background defrag; this test drives defrag manually via
triggerSnapshotDefrag().
+ conf.setInt(OZONE_SNAPSHOT_DEFRAG_SERVICE_INTERVAL, -1);
Review Comment:
Actually `-1` won't work. `SnapshotDefragService` is not created with
interval <= 0. `om.triggerSnapshotDefrag(false)` throws FEATURE_NOT_ENABLED,
which these helpers catch and retry until DEFRAG_WAIT_MS expires.
Please use a positive duration with explicit units, for example
`conf.setTimeDuration(OZONE_SNAPSHOT_DEFRAG_SERVICE_INTERVAL, 7200,
TimeUnit.SECONDS)`, so the service remains available for manual triggers
without another periodic run during the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
