aryangupta1998 commented on code in PR #10894:
URL: https://github.com/apache/ozone/pull/10894#discussion_r3740712319
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataReader.java:
##########
@@ -259,8 +259,40 @@ public List<OzoneFileStatus> listStatus(OmKeyArgs args,
boolean recursive,
public List<OzoneFileStatusLight> listStatusLight(OmKeyArgs args,
boolean recursive, String startKey, long numEntries,
boolean allowPartialPrefixes) throws IOException {
- List<OzoneFileStatus> ozoneFileStatuses =
- listStatus(args, recursive, startKey, numEntries,
allowPartialPrefixes);
+ long maxListingPageSize = ozoneManager.getConfiguration().getInt(
+ OZONE_FS_LISTING_PAGE_SIZE_MAX,
+ OZONE_FS_LISTING_PAGE_SIZE_DEFAULT);
+ maxListingPageSize = OzoneConfigUtil.limitValue(numEntries,
+ OZONE_FS_LISTING_PAGE_SIZE, OZONE_FS_LISTING_PAGE_SIZE_MAX,
+ maxListingPageSize);
+
+ ResolvedBucket bucket = ozoneManager.resolveBucketLink(args);
+ boolean auditSuccess = true;
+ Map<String, String> auditMap = bucket.audit(args.toAuditMap());
+ OmKeyArgs resolvedArgs = bucket.update(args);
+
+ List<OzoneFileStatus> ozoneFileStatuses;
+ try {
+ if (isAclEnabled) {
+ checkAcls(getResourceType(resolvedArgs), StoreType.OZONE, ACLType.READ,
+ bucket, resolvedArgs.getKeyName());
+ }
+ metrics.incNumListStatus();
+ ozoneFileStatuses = keyManager.listStatus(resolvedArgs, recursive,
+ startKey, maxListingPageSize, getClientAddress(),
+ allowPartialPrefixes, false);
+ } catch (Exception ex) {
+ metrics.incNumListStatusFails();
+ auditSuccess = false;
+ audit.logReadFailure(buildAuditMessageForFailure(OMAction.LIST_STATUS,
+ auditMap, ex));
+ throw ex;
+ } finally {
+ if (auditSuccess) {
Review Comment:
Removed success audit from finally; failure audit remains in catch, so we no
longer risk auditing success if conversion fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
