chungen0126 commented on PR #10651: URL: https://github.com/apache/ozone/pull/10651#issuecomment-5241958736
> Fair question on the client-side cost. My reading is that ockrw is a pure benchmark, it reads and discards the bytes, so it needs no digest. This one is in the validator family (dfsv / ockv), which already digests every read, and [HDDS-14524](https://issues.apache.org/jira/browse/HDDS-14524) explicitly asks to keep a hash per file and validate it on read-back. Dropping validation would make this overlap with ockrw, so I'd rather keep it. Thanks @chihsuan for the explanation. In my view, Freon is primarily a stress testing tool meant to capture metrics like latency bottlenecks under load, while data integrity validation naturally belongs to E2E / integration testing. Computing hashes on every operation introduces client-side overhead that can pollute metrics and make the client CPU the bottleneck. Therefore, I don't think we should include validation here. However, I'd also like to hear what others think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
